Agreed that as a professional athlete, lifting weights with the right approach for your sport is definitely a win. You'll notice that as fitness and nutrition (well, plus PEDs) have developed, modern athletes across sports are incredibly stronger, faster, more powerful, and more massive than they were historically, but that's much less true in golf. There's only a handful or two of top guys who you would describe as cut like dedicated weight lifters with low body fat, and none of them have gotten all massive like so many athletes in the all other major sports (not counting soccer as a major sport in the U.S.).
That's why I advocate sticking to body weight exercise these days. Really my only sport now is golf, where you want lean strength with flexibility, and I'd argue that's easier to achieve as an amateur athlete with a job and family outside the weight room. The sort of standard American ex-high school/college athlete exercise routine consisting of weight lifting, cardio, and some pro forma warm up or cool down stretching (a 10-20 minute cool down stretch is just pro forma), as practiced by a lot of my friends from my college baseball team for example, doesn't actually produce great results in all around useable strength, body control, stabilization, or flexibility.
An example of what I mean. My wife and I do some recreational partner acrobatics. One session at our school this new guy joined the partner class. We were training for hand-to-foot, which is when the flyer (my wife) stands on the base's (my) hands as I'm standing with my arms straight above my head. A practice and conditioning exercise is to have the flyer stand on the base's hands while he lies on his back and essentially bench presses the flyer x times. The new guy was ripped, clearly a very dedicated lifter. I would do sets of 5 presses with my wife standing on my hands. The new guy couldn't do it once on his own, and even with a spot keeping my wife in balance he could only do it once, wobbling all over the place. I know from all the time I spent in the weight room in college and from looking at him and seeing some of the other stuff he could do that his max bench was, minimum, double my wife's weight, probably closer to 2.5x. But he'd only built strength in his big muscles. Even lifting with dumbbells doesn't build core and stabilization muscles anything like body weight work. And he was super stiff everywhere to boot. From what I've seen those are pretty typical results for adults whose exercise consists entirely of weight lifting, cardio, and some reluctant stretching.
This is not to say that all amateur adults who lift weights fall into that trap! I just think it's easier (and more fun IMO) to achieve the kind of fitness goals needed for an amateur golfer and just general health if you avoid the weight room. If you're not at risk for injury and not too proud to do much less with proper form, of course something like CrossFit can achieve those goals, though for golf I'd advocate stretching more than most CrossFitters seem to.