I dont do a full swing, I just go a half swing, trying to get the right feel through and making sure that Im rolling my arms and having the back of my left hand facing the target at impact. Moment of impact is all that really matters anyways.
Typically - do you take a FULL practice swing before every shot ? - Page 3
TheSandTrap.com Top Picks
If you are taking divots with a practice swing, then you are practicing poor etiquette. Part of the player's etiquette responsibilities is to respect and care for the course, and taking divots when you aren't hitting the ball doesn't qualify.
Edit: Oops, forgot to multiquote... sorry guys.
The first few years I played I took a full practice swing, more specifically a practice swing that matched whatever shot I was going to attempt. Over the years it's morphed into just two half like swings while I'm standing behind the ball picking out my target. Then at address I get set, play the shot in my mind and then swing away!
I want to get away from playing the shot in my mind, I fell like I get "stuck" sometimes and it screws up my tempo. I've played some of my best golf when I'm rushing a round because I didn't really have time to play and went away. Those days usually go pretty well. So this year I'm going to focus on picking my target and committing to my shot and just doing it! Spending less time over analyzing things.