You don't have to be a good golfer to be a good analyst. That logic would also mean that you'd have to be a good golfer to be a good golf coach. I don't think Haney, Harmon(s), or Foley were good golfers. Do any of them have any professional wins?
Now, is Brandel a good swing analyst? Probably not ... but he is very good at his job, and I do think that some of those other guys are as well. Especially Nobilo. :)
I kinda like Faxon too, especially after his comment about wanting to go to the same dentist as Rory.